Skip to content

fix(cloudflare): reduce dns & custom hostnames list api calls #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(cloudflare): reduce dns & custom hostnames list api calls #5290

wants to merge 1 commit into from
+138 −66

Conversation

vflaux
Copy link
Contributor

@vflaux vflaux commented Apr 14, 2025 •
edited
Loading

Description

List cloudflare DNS records & custom hostnames only once per zone instead of one per change.

For this to work we need to reflect changes made on the api into CustomHostnamesMap & DNSRecordsMap. (Only updating CustomHostnamesMap is actually needed for the tests to pass, so maybe we could ignore changes with DNSRecordsMap)

I don't use custom hostnames so I have not tested it in a cluster.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2025
@ivankatliarchuk
Copy link
Contributor

This pull request will likely need to adopt an approach similar to AWS's, with enable/disable caching. If caching is enabled, we'd expect to see fewer API calls, but with a corresponding increase in memory usage.

@vflaux vflaux force-pushed the refact_cloudflare_dns_n_ch_listing branch from c6a4e74 to 9f9d464 Compare June 3, 2025 12:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2025
@vflaux
Copy link
Contributor Author

vflaux commented Jun 3, 2025

This pull request will likely need to adopt an approach similar to AWS's, with enable/disable caching. If caching is enabled, we'd expect to see fewer API calls, but with a corresponding increase in memory usage.

This should not really impact the memory usage.
Maps of DNSRecords & CustomHostnames are build for each change after calling the api.
This PR simply build them once then update them after each call (create/update/delete) to the api.

@ivankatliarchuk
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

@vflaux: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-external-dns-unit-test 9f9d464 link true /test pull-external-dns-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ivankatliarchuk
Copy link
Contributor

Would be great to see actual reduce of API requets. Here is an example I did for AWS pull zones with tags in batchess

Screenshot 2025-06-07 at 14 35 17

after (17 api calls)
Screenshot 2025-06-07 at 14 35 32

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vflaux @k8s-ci-robot @ivankatliarchuk